Skip to content

style: remove unnecessary semicolon after namespace#8410

Merged
chrchr-github merged 1 commit intodanmar:mainfrom
vil02:remove_unnecessary_semicolon
Apr 4, 2026
Merged

style: remove unnecessary semicolon after namespace#8410
chrchr-github merged 1 commit intodanmar:mainfrom
vil02:remove_unnecessary_semicolon

Conversation

@vil02
Copy link
Copy Markdown
Contributor

@vil02 vil02 commented Apr 4, 2026

While running the build, one can see

lib/analyzerinfo.h:38:2: warning: extra ';' [-Wpedantic]
   38 | };

This PR fixes that.

This removes the extra ';' warning occurring in the build.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 4, 2026

@vil02 vil02 marked this pull request as ready for review April 4, 2026 08:23
@chrchr-github
Copy link
Copy Markdown
Collaborator

Thanks for your contribution. If you'd like, you can add yourself to the AUTHORS file.

@vil02
Copy link
Copy Markdown
Contributor Author

vil02 commented Apr 4, 2026

Thanks for your contribution. If you'd like, you can add yourself to the AUTHORS file.

I will do that, when I will contribute something more significant.

@chrchr-github chrchr-github merged commit db9f970 into danmar:main Apr 4, 2026
72 checks passed
@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Apr 4, 2026

Which compiler is generating this warning? I remember seeing it recently but I forgot in which context.

@vil02 vil02 deleted the remove_unnecessary_semicolon branch April 4, 2026 21:25
@vil02
Copy link
Copy Markdown
Contributor Author

vil02 commented Apr 4, 2026

Which compiler is generating this warning?

Unfortunately I cannot reproduce it. It was a very hacky setup.

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Apr 4, 2026

Unfortunately I cannot reproduce it. It was a very hacky setup.

That is a very bad foundation for basing any changes on. We usually try to be able to reproduce things in the CI before making any changes. Otherwise things might regress (again) in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants